Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update trim messages guide #23418

Merged
merged 1 commit into from
Jun 25, 2024
Merged

docs: update trim messages guide #23418

merged 1 commit into from
Jun 25, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Jun 25, 2024

@ccurme ccurme requested a review from baskaryan June 25, 2024 19:28
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 7:50pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 25, 2024
@@ -422,7 +415,7 @@
"\n",
"def dummy_get_session_history(session_id):\n",
" if session_id != \"1\":\n",
" raise InMemoryChatMessageHistory()\n",
" return InMemoryChatMessageHistory()\n",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @baskaryan to confirm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Jun 25, 2024
@ccurme ccurme enabled auto-merge (squash) June 25, 2024 19:35
@ccurme ccurme merged commit f788d09 into master Jun 25, 2024
13 checks passed
@ccurme ccurme deleted the cc/update_guide branch June 25, 2024 19:50
mandos21 pushed a commit to mandos21/langchain that referenced this pull request Jul 8, 2024
- rerun to remove warnings following
langchain-ai#23363
- `raise` -> `return`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant