Skip to content

Commit

Permalink
fix: removed auto height to fix glitch on Edit Tools (#5815)
Browse files Browse the repository at this point in the history
Removed auto height from table node component

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
  • Loading branch information
lucaseduoli and ogabrielluiz authored Jan 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 14773bb commit 6f04e57
Showing 3 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -161,7 +161,6 @@ export default function TableNodeComponent({
setSelectedNodes(event.api.getSelectedNodes());
}}
rowSelection={table_options?.block_select ? undefined : "multiple"}
suppressRowClickSelection={true}
editable={editable}
pagination={!table_options?.hide_options}
addRow={addRow}
4 changes: 1 addition & 3 deletions src/frontend/src/modals/tableModal/index.tsx
Original file line number Diff line number Diff line change
@@ -2,11 +2,9 @@ import ForwardedIconComponent from "@/components/common/genericIconComponent";
import TableComponent, {
TableComponentProps,
} from "@/components/core/parameterRenderComponent/components/tableComponent";
import { Button } from "@/components/ui/button";
import { TableOptionsTypeAPI } from "@/types/api";
import { DialogClose } from "@radix-ui/react-dialog";
import { AgGridReact } from "ag-grid-react";
import { ElementRef, ForwardedRef, forwardRef } from "react";
import { ForwardedRef, forwardRef } from "react";
import BaseModal from "../baseModal";

interface TableModalProps extends TableComponentProps {
4 changes: 2 additions & 2 deletions src/frontend/src/utils/utils.ts
Original file line number Diff line number Diff line change
@@ -562,8 +562,8 @@ export function FormatColumns(columns: ColumnField[]): ColDef<any>[] {
};
if (col.formatter !== FormatterType.text || col.edit_mode !== "inline") {
if (col.edit_mode === "popover") {
newCol.wrapText = true;
newCol.autoHeight = true;
newCol.wrapText = false;
newCol.autoHeight = false;
newCol.cellEditor = "agLargeTextCellEditor";
newCol.cellEditorPopup = true;
newCol.cellEditorParams = {

0 comments on commit 6f04e57

Please sign in to comment.