Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty delete bug #12339

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix: empty delete bug #12339

merged 2 commits into from
Jan 3, 2025

Conversation

huangzhuo1949
Copy link
Contributor

@huangzhuo1949 huangzhuo1949 commented Jan 3, 2025 •
edited by crazywoola
Loading

Summary

Resolve #12345

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 3, 2025
@crazywoola
Copy link
Member

Please open an issue or link existing an issue in the description.

@crazywoola
Copy link
Member

Please run dev/reformat to resolve the lint errors.

@huangzhuo1949 huangzhuo1949 mentioned this pull request Jan 3, 2025
Closed
5 tasks
@huangzhuo1949
Copy link
Contributor Author

Please run dev/reformat to resolve the lint errors.

done~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2025
@crazywoola crazywoola merged commit 7069802 into langgenius:main Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@JohnJyong JohnJyong JohnJyong approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug：vdb delete empty list
3 participants
@huangzhuo1949 @crazywoola @JohnJyong