Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get property of string type variable caused page crash #12969

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Jan 23, 2025

Summary

Fix: get property of string type variable caused page crash.

Screenshots

image
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@iamjoel iamjoel requested a review from YIXIAO0 January 23, 2025 02:57
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@iamjoel iamjoel merged commit f565f08 into main Jan 23, 2025
8 checks passed
@iamjoel iamjoel deleted the fix/page-app-crash branch January 23, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants