Fix docstring of DCPPowerModel #911
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 94.19% 93.85% -0.35%
==========================================
Files 43 43
Lines 9618 9589 -29
==========================================
- Hits 9060 9000 -60
- Misses 558 589 +31
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/core/types.jl
Outdated
| @@ -156,7 +156,7 @@ abstract type AbstractDCPModel <: AbstractActivePowerModel end | |||
| Linearized 'DC' power flow Model with polar voltage variables. | |||
|
|
|||
| This model is a basic linear active-power-only approximation, which uses branch susceptance values | |||
| `br_b = -br_x / (br_x^2 + br_x^2)` for determining the network phase angles. Furthermore, transformer | |||
| `br_b = -br_x / (br_x^2 + br_r^2)` for determining the network phase angles. Furthermore, transformer | |||
There was a problem hiding this comment.
This is a correct fix but the convention is that r comes before x, so (br_r^2 + br_x^2) would be more standard.
the reason is the complex number Z = r + x im, then |Z|^2 = r^2 + x^2
|
Thanks! |
Closes #910
I don't have the domain knowledge to know whether this is correct.