Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tranpose operations to support non-symmetric matrix structure. #727

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

oseikuffuor1
Copy link
Collaborator

  • Modified ellpack and ellblock to correctly support arbitrary structure.
  • Updated csr transpose algo. to be consistent with new ellpack algo.

* Modified ellpack and ellblock to correctly support arbitrary structure.
* Updated csr transpose algo. to be consistent with new ellpack algo.
Copy link
Collaborator

@jeanlucf22 jeanlucf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep the old code? Removing it may also help in seeing the differences between the old and the new

@oseikuffuor1
Copy link
Collaborator Author

Why keep the old code? Removing it may also help in seeing the differences between the old and the new

@jeanlucf22 that was unintended for csr and ellblock. I will remove those. For ellpack, both are actually new code. I left comments at the beginning of the code to explain the difference between the two. The first is likely better for matrices with non symmetric structure, and the second is likely better for matrices with symmetric structure. For general matrices, I think either option should be fine. I left that in there so we can discuss it at our meeting tomorrow.

* Cleaned up old transpose code that was commented out.
* Updated header files to include TYPED helper functions.
@jeanlucf22
Copy link
Collaborator

Why keep the old code? Removing it may also help in seeing the differences between the old and the new

@jeanlucf22 that was unintended for csr and ellblock. I will remove those. For ellpack, both are actually new code. I left comments at the beginning of the code to explain the difference between the two. The first is likely better for matrices with non symmetric structure, and the second is likely better for matrices with symmetric structure. For general matrices, I think either option should be fine. I left that in there so we can discuss it at our meeting tomorrow.

@oseikuffuor1 Looks good once you fix the formatting

@oseikuffuor1
Copy link
Collaborator Author

Why keep the old code? Removing it may also help in seeing the differences between the old and the new

@jeanlucf22 that was unintended for csr and ellblock. I will remove those. For ellpack, both are actually new code. I left comments at the beginning of the code to explain the difference between the two. The first is likely better for matrices with non symmetric structure, and the second is likely better for matrices with symmetric structure. For general matrices, I think either option should be fine. I left that in there so we can discuss it at our meeting tomorrow.

@oseikuffuor1 Looks good once you fix the formatting

@jeanlucf22, all fixed now. Thanks.

@jeanlucf22 jeanlucf22 self-requested a review August 23, 2023 21:53
@jeanlucf22 jeanlucf22 merged commit 35399ef into lanl:master Aug 23, 2023
@oseikuffuor1 oseikuffuor1 deleted the sparse-transpose branch September 25, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants