Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize "domain" code #732

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Reorganize "domain" code #732

merged 1 commit into from
Sep 7, 2023

Conversation

jeanlucf22
Copy link
Collaborator

No description provided.

@jeanlucf22
Copy link
Collaborator Author

@cnegre @ares201005 Could you check if I did not break anything with those changes? We have no test for the domain struct in BML, but it seems to be used in PROGRESS

@jeanlucf22
Copy link
Collaborator Author

@cnegre @ares201005 Could you check if I did not break anything with those changes? We have no test for the domain struct in BML, but it seems to be used in PROGRESS

@cnegre @ares201005 : any comment?

@ares201005
Copy link
Contributor

ares201005 commented Sep 6, 2023 •
edited
Loading

@cnegre @ares201005 Could you check if I did not break anything with those changes? We have no test for the domain struct in BML, but it seems to be used in PROGRESS

@cnegre @ares201005 : any comment?

Sure, I will check it this afternoon.

Updates: prg_subgraph is only subroutine using bml_domain and nothing is broken by this commit.

@jeanlucf22 jeanlucf22 merged commit 37f6087 into lanl:master Sep 7, 2023
@jeanlucf22 jeanlucf22 deleted the domain branch September 7, 2023 02:29
@jeanlucf22
Copy link
Collaborator Author

@ares201005 Is there a need to add a new test in PROGRESS to make sure we don't break that functionality?

@jeanlucf22 jeanlucf22 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suemni suemni suemni approved these changes

@nicolasbock nicolasbock Awaiting requested review from nicolasbock nicolasbock is a code owner

@cnegre cnegre Awaiting requested review from cnegre cnegre is a code owner

@tokshgithub tokshgithub Awaiting requested review from tokshgithub tokshgithub is a code owner

@jmohdyusof jmohdyusof Awaiting requested review from jmohdyusof jmohdyusof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanlucf22 @ares201005 @suemni