Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add *bsd targets #985

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: add *bsd targets #985

merged 1 commit into from
Aug 23, 2022

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Aug 22, 2022

target_family = "unix" includes all Unix-like systems, like *BSD, etc.

@MinusGix MinusGix added P-linux This issue affects Linux users and removed P-linux This issue affects Linux users labels Aug 22, 2022
@dzhou121
Copy link
Collaborator

Can Lapce build on *BSD?

@panekj
Copy link
Collaborator Author

panekj commented Aug 22, 2022

Can Lapce build on *BSD?

According to this https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265892#c16, yes

@dzhou121
Copy link
Collaborator

Maybe using #[cfg(any(target_os = "linux", target_os = "openbsd"))]

@panekj
Copy link
Collaborator Author

panekj commented Aug 22, 2022

That doesn't include target_os = "freebsd", also I prefer to be inclusive in such declarations and only exclude when it doesn't work on some other platform

@dzhou121
Copy link
Collaborator

That's how it is on Druid. So I'm really surprised.

I'm thinking the other way around. You add the thing that you know that's gonna work.

@panekj panekj force-pushed the fix/bsd branch 2 times, most recently from e4177e1 to a854029 Compare August 22, 2022 16:06
@panekj panekj changed the title fix: use target_family instead of target_os fix: add *bsd targets Aug 22, 2022
@rtsuk
Copy link
Contributor

rtsuk commented Aug 22, 2022

Last time I checked, Rust considers MacOS as Unix-like, which might make that config less useful for something like Lapce.

@panekj
Copy link
Collaborator Author

panekj commented Aug 22, 2022

Last time I checked, Rust considers MacOS as Unix-like, which might make that config less useful for something like Lapce.

That's why there was not(target_os = "macos") but you're commenting on already out of date information.

@rtsuk
Copy link
Contributor

rtsuk commented Aug 22, 2022

Yep, just adding what I thought was a useful fact. Sorry for the noise.

@dzhou121 dzhou121 merged commit 9ebb597 into lapce:master Aug 23, 2022
@panekj panekj deleted the fix/bsd branch August 23, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants