Use Config to Generate Better Data #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Establish a config file (modelfromtable.php) that devs can use to preset configurations (which can be overridden by command line) - downside is debug, all, etc have to be explicitly set to true in command line - Use `app/Models` directory if Laravel 8+ (laracademy#40) - New configuration to enable/disable timestamps (laracademy#13) - Generating model docblocks (laracademy#7) - New configuration to set delimiter (esp useful for tables with a lot of columns) - New configuration that sets `overwrite` to `false` by default, much safer for models that a dev has created and modified (force them to overwrite explicitly) - New configuration that sets `$primaryKey` - supports lambda to run database-specific query to obtain the primary key column - Expanded on previous `$cast` types, tried to make it a little smarter with regexp - New configurations for whitelist and blacklist ("migrations" table included in config's blacklist by default, so devs have the choice to include it or not) - General stub cleanup
|
I think is a huge improvement! I will check everything out this weekend, but looking at the files I like what I see :) |
This was referenced Oct 7, 2020
Closed
johnneijzen
added a commit
to johnneijzen/generators
that referenced
this pull request
Nov 19, 2020
update README.MD to reflected laracademy#41 changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if this is too much change for one PR; I got on a bit of a run with the config feature (and a few things I needed to work with a very large database - specifically white/black listing) and thought I could also help fix some of the issues others had while I was in here.
Once I have your feedback and blessing, I can update the documentation here or in another PR.
app/Modelsdirectory if Laravel 8+ (Laravel 8 Models #40)overwritetofalseby default, much safer for models that a dev has created and modified (force them to overwrite explicitly)$primaryKey- supports lambda to run database-specific query to obtain the primary key column$casttypes, tried to make it a little smarter with regex