Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile need test too, should hide WeChat service account on web… #34

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

sinkcup
Copy link
Member

@sinkcup sinkcup commented Sep 10, 2019

#33

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #34 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     90.22%   90.83%   +0.61%     
- Complexity       76       80       +4     
============================================
  Files            13       15       +2     
  Lines           225      240      +15     
============================================
+ Hits            203      218      +15     
  Misses           22       22
Impacted Files Coverage Δ Complexity Δ
src/SocialiteCommand.php 91.93% <ø> (-0.38%) 22 <0> (ø)
src/Socialite/Controllers/Controller.php 100% <100%> (ø) 5 <5> (?)
...cialite/Controllers/Settings/ProfileController.php 100% <100%> (ø) 3 <3> (?)
...Socialite/Controllers/SocialiteLoginController.php 76.27% <100%> (-2.2%) 15 <0> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8c7ff...85b8b85. Read the comment docs.

@sinkcup sinkcup merged commit 7bc2aeb into master Sep 10, 2019
@sinkcup sinkcup deleted the issue-33 branch September 10, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant