Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation methods to Blade stack #215

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Nov 16, 2022

Edit: Just found out a similar PR was closed. I still think this is good for consistency as the rest of the Blade views already have this.

@askdkc
Copy link

askdkc commented Nov 17, 2022

I guess keeping {{__('TEXT')}} syntax for Breeze and Jetstream is really helpful and educational for those who want to create multi-language support web apps in Laravel.

Since Breeze and Jetstrem are starter kits, those consistencies are also preferable for new Laravel learners too.

(this is just my experience though, but I learned a lot from Breeze and Jetstream)

Really hoping this PR gets merged🙏

@taylorotwell taylorotwell merged commit f487c87 into 1.x Nov 17, 2022
@taylorotwell taylorotwell deleted the lost-in-translation branch November 17, 2022 15:12
slimani-dev pushed a commit to slimani-dev/breeze that referenced this pull request Jan 21, 2023
* Add missing translation methods to Blade stack

* formatting

* formatting

Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants