Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed isFocused prop on TextInput component #232

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Renamed isFocused prop on TextInput component #232

merged 1 commit into from
Dec 19, 2022

Conversation

drewmw5
Copy link
Contributor

@drewmw5 drewmw5 commented Dec 16, 2022

autofocus does not exist as a prop on the TextInput component. Renaming the prop to isFocused results in the text input auto focusing.

Thanks.

timacdonald
timacdonald approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@timacdonald timacdonald left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed issue exists, only impacts this page, and is not an issue for the Vue stack.

This fixes it. Thanks!

@driesvints driesvints merged commit 9f4fc13 into laravel:1.x Dec 19, 2022
@driesvints
Copy link
Member

Thanks!

@drewmw5 drewmw5 deleted the pr branch December 26, 2022 02:31
slimani-dev pushed a commit to slimani-dev/breeze that referenced this pull request Jan 21, 2023
@drewmw5 @slimani-dev
Fixed name of isFocused prop (laravel#232)
aca9d16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewmw5 @driesvints @timacdonald