Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Inertia v1 #238

Merged
merged 12 commits into from
Jan 17, 2023
Merged

[1.x] Inertia v1 #238

merged 12 commits into from
Jan 17, 2023

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jan 13, 2023 •
edited
Loading

This PR updates the Breeze Vue and React stacks for Inertia v1.

TODO:

  • Update package constraints to ^1.0.0 when released.
  • Determine appropriate ssr.noExternal setting in vite.config.js files or whether it can be removed.

@jessarcher jessarcher changed the title Inertia v1 [1.x] Inertia v1 Jan 15, 2023
@jessarcher jessarcher marked this pull request as ready for review January 17, 2023 00:35
@jessarcher
Remove creation of Inertia config on SSR install
ef38625 
This is no longer required as Inertia will automatically detect SSR.
@jessarcher
Remove ssr.noExternal from Vite config
423ce87 
This doesn't seem to be required any longer.
@reinink
Copy link
Contributor

reinink commented Jan 17, 2023

Beautiful! 😍

@taylorotwell taylorotwell merged commit 4280282 into 1.x Jan 17, 2023
@taylorotwell taylorotwell deleted the inertia-v1 branch January 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinink reinink reinink left review comments

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessarcher @reinink @timacdonald @taylorotwell