Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Improve React components #257

Merged
merged 3 commits into from
Feb 15, 2023
Merged

[1.x] Improve React components #257

merged 3 commits into from
Feb 15, 2023

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Feb 15, 2023

This PR makes the following changes to the React components (and their usage throughout the application):

  • Additional props are now passed to the underlying HTML element (similar to Vue). This allows us to remove explicit props for things like id, autoComplete, and required.
  • The forInput prop has been removed in favour of passing the standard JSX htmlFor through.
  • The handleChange prop on TextInput has been removed in favour of passing the standard JSX onChange through.
  • The processing prop on buttons has been changed to disabled to reflect better what it's doing and also to match the Vue stack.
  • All components customising the className of an underlying element now accept a className prop that will be appended to the underlying element. Previously only some components were doing this.
  • Explicit props that specify a redundant default (i.e. the same default as the underlying component) have been removed.

@jessarcher jessarcher marked this pull request as ready for review February 15, 2023 06:35
@taylorotwell taylorotwell merged commit a300bc2 into 1.x Feb 15, 2023
@taylorotwell taylorotwell deleted the improve-react-components branch February 15, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants