Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Prop consistency #272

Merged
merged 6 commits into from
Mar 8, 2023
Merged

[1.x] Prop consistency #272

merged 6 commits into from
Mar 8, 2023

Conversation

jessarcher
Copy link
Member

This PR makes the following opinionated changes:

React

  • All props are now destructured to clearly show what props are available.
  • The AuthenticatedLayout component now accepts the user object directly. It is also no longer passed the errors prop which it wasn't using.

Vue

  • There were three different usage styles of defineProps so I've made them all consistently the full format.
  • The checked prop of the Checkbox component is now required.
  • The redundant type prop has been removed from PrimaryButton and DangerButton. These are already submit by default and can be changed without a prop.

These changes all made it easier to convert the stubs to TypeScript in #267. I believe they will also make it easier for users that want to adopt linters like https://eslint.vuejs.org/ in their projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants