Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Copied #30101 #137

Merged
merged 2 commits into from
Jul 30, 2020
Merged

[5.x] Copied #30101 #137

merged 2 commits into from
Jul 30, 2020

Conversation

bytestream
Copy link
Contributor

@bytestream bytestream changed the base branch from 6.x to 5.0 July 30, 2020 13:22
@bytestream bytestream changed the title Copied #30101 [5.x] Copied #30101 Jul 30, 2020
@bytestream bytestream mentioned this pull request Jul 30, 2020
Closed
@driesvints
Copy link
Member

@bytestream it's always best that you also add an explanation instead of linking to an issue/pr. See the PR template.

@bytestream
Copy link
Contributor Author

I think the linked PR provides a more than adequate explanation of why the functionality is beneficial. This PR simply copies it's work. There's not much more that can be said.

The use of traits in Illuminate\Foundation\Testing and this package make it difficult to reuse the functionality added by that PR. I'd rather not have to pull in both traits and write a long list of conflict resolutions for every conflicting method.

@taylorotwell taylorotwell merged commit c202f99 into laravel:5.0 Jul 30, 2020
@jshah4517
Copy link

@driesvints Is it possible to have a new 5.x release including this?

@driesvints
Copy link
Member

@jshah4517 I'll try to look into this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bytestream @driesvints @jshah4517 @taylorotwell