Limiting length of getCallerName return value to avoid issue when sto…

…ring logs and screenshots (#1070) * Limiting length of getCallerName return value to avoid issue when storing logs and screenshots * Adding a test to verify that test name is truncated correctly
laravel · Nov 14, 2023 · 99df89a · 99df89a
1 parent fa6c39f
commit 99df89a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Concerns/ProvidesBrowser.php b/src/Concerns/ProvidesBrowser.php
@@ -232,7 +232,7 @@ protected function getCallerName()
             ? $this->name()
             : $this->getName(false); // @phpstan-ignore-line
 
-        return str_replace('\\', '_', get_class($this)).'_'.$name;
+        return str_replace('\\', '_', substr(get_class($this), 0, 70)).'_'.substr($name, 0, 70);
     }
 
     /**

diff --git a/tests/Unit/ProvidesBrowserTest.php b/tests/Unit/ProvidesBrowserTest.php
@@ -44,6 +44,17 @@ public function test_store_console_logs_for()
         $this->storeConsoleLogsFor($browsers);
     }
 
+    public function test_truncate_test_name_where_that_name_is_too_long_and_might_cause_issues()
+    {
+        $browser = m::mock(stdClass::class);
+        $browser->shouldReceive('storeConsoleLog')->with(
+            'Laravel_Dusk_Tests_Unit_ProvidesBrowserTest_test_truncate_test_name_where_that_name_is_too_long_and_might_cause_is-0'
+        );
+        $browsers = collect([$browser]);
+
+        $this->storeConsoleLogsFor($browsers);
+    }
+
     public static function testData()
     {
         return [