[7.x] Fix tests #1024
Merged
[7.x] Fix tests #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @crynobone |
crynobone
reviewed
Feb 10, 2023
src/Console/DuskCommand.php
Outdated
| @@ -282,7 +283,11 @@ protected function writeConfiguration() | |||
| { | |||
| if (! file_exists($file = base_path('phpunit.dusk.xml')) && | |||
| ! file_exists(base_path('phpunit.dusk.xml.dist'))) { | |||
| copy(realpath(__DIR__.'/../../stubs/phpunit.xml'), $file); | |||
| if (version_compare(Application::VERSION, '10.0.0') >= 0) { | |||
There was a problem hiding this comment.
But this doesn't guarantee PHPUnit 10 is installed, maybe use version_compare() against phpunit instead?
|
@driesvints please mark as ready for review when feedback addressed. |
crynobone
reviewed
Feb 14, 2023
crynobone
reviewed
Feb 14, 2023
Co-authored-by: Mior Muhammad Zaki <[email protected]>
Co-authored-by: Mior Muhammad Zaki <[email protected]>
|
Ready again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.