Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use WebDriverWait available API for WaitsForElements trait instead of relying on Carbon. #1062

Merged
merged 25 commits into from
Oct 10, 2023
Merged

Consistently use WebDriverWait available API for WaitsForElements trait instead of relying on Carbon. #1062

merged 25 commits into from
Oct 10, 2023

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Oct 9, 2023 •
edited
Loading

Benefits of these changes:

  • waitUsing() doesn't need to mimic WebDriverWait exception and now can fully utilise any new enhanced from WebDriverWait.
  • Relying on Carbon combined with freezing time may cause bad expectations. WebDriverWait only uses microtime() and usleep().

crynobone and others added 25 commits September 27, 2023 15:09
@crynobone
wip
5e04163 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@StyleCIBot
Apply fixes from StyleCI
82d9a5a
@crynobone
wip
ecbeca6 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Merge remote-tracking branch 'upstream/refactor' into refactor
2dc3e33
@crynobone
wip
3a576c5 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
b6f6b3e 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
cddc90d 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
ae988dc 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
e3af8eb 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
3680943 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
713ac6a 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
3c1c333 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
7ced366 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
994f1dd 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@StyleCIBot
Apply fixes from StyleCI
7f9aff1
@crynobone
wip
849530d 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Merge remote-tracking branch 'upstream/refactor' into refactor
5b8b015
@crynobone
wip
63f3a30 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
8da562a 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
409c320 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
47100c2 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
62b97b3 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@StyleCIBot
Apply fixes from StyleCI
2816172
@crynobone
wip
9c1171d 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Merge remote-tracking branch 'upstream/refactor' into refactor
12945de
@taylorotwell taylorotwell marked this pull request as draft October 9, 2023 14:50
@crynobone crynobone marked this pull request as ready for review October 10, 2023 01:46
@taylorotwell taylorotwell merged commit ae5a90c into 7.x Oct 10, 2023
22 checks passed
@taylorotwell taylorotwell deleted the refactor branch October 10, 2023 12:57
@voidgraphics voidgraphics mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crynobone @taylorotwell @StyleCIBot