Add PHPUnit data provider set name to output filenames #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
Can we make the PR not change the names of screenshots for tests that use no data set? |
|
@taylorotwell I've pushed a test to prove the filenames are unchanged if there's no data set. |
ziadoz
commented
Feb 9, 2024
| ); | ||
| $browsers = collect([$browser]); | ||
|
|
||
| $this->storeConsoleLogsFor($browsers); | ||
| } | ||
|
|
||
| public static function testData() | ||
| public static function data() |
There was a problem hiding this comment.
I took the test prefix off of this because PHPUnit is running the method as a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a failure in a Dusk test case that uses PHPUnit data providers, then only a screenshot of the last data set that failed will be available in the
screenshotsdirectory. This is because without the data set in the filename, each new screenshot overwrites the previous one.This PR adds the data set, where applicable, to the filenames of screenshots and console output:
With no data provider:
With unnamed data set (
0,1):With named data set (
foo,bar):I've retained the existing 140 character filename limit by trimming it off the left hand side of the filename, so namespaces are truncated.