Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation messages on PHPUnit 8 #620

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

mnabialek
Copy link
Contributor

assertContains and assertNotContains are deprecated in PHPUnit 8, so we need to use assertTrue and assertFalse together with Str::contains if we want to also support PHPUnit < 7.5

@driesvints
Copy link
Member

Heya, thanks for sending this in. I've, however, replaced these with the proper PHPUnit assertions instead of using our own Str helper. Here's the commit: d48f990

@driesvints driesvints closed this Mar 1, 2019
@mnabialek
Copy link
Contributor Author

@driesvints But it won't work when someone is using PHPUnit 7, those assertions were introduced in PHPUnit 7,5 I believe and in composer.json we allow any PHPUnit 7 version

@driesvints driesvints reopened this Mar 1, 2019
@driesvints
Copy link
Member

@mnabialek good catch 👍

Wasn't aware that they were only added then.

@driesvints driesvints merged commit 6d6ab62 into laravel:5.0 Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants