[5.x] Add assert attribute methods #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
This was referenced Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the only attribute we can check is the
valueattribute using theasserValue. This PR adds three new methods:assertAttribute(),assertDataAttribute()and `assertAriaAttribute().I admit in my use case I would only need
assertAriaAttribute(), but I think all three would be useful methods.Use case
I have a CRUD page where the button to add an item is a simple plus icon
Because it's just an icon, I use the
aria-labelattribute.I want to test that not only the button is visible, but also that is has the correct attribute, but also that it contains the correct value.