Fix unicode support in appendSlowly method #907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we use for example Cyrillic symbols in
typeSlowly
orappendSlowly
methods, they are processed withstr_split
function, which does not correctly processes unicode characters.will return:
After that, web-driver will send the
sendKeysToElement
command with parameters similar as follows: "�" instead of{"text":"О",":id": ...}
Server will respond to this request with the following exception: "invalid argument: missing command parameters".
Replacing
str_split
withmb_str_split
(PHP >= 7.4) or withpreg_split('\\u', ...)
fix this issue.And server will receive correct command parameters:
sendKeysToElement || {"text":"\u0430",":id": ...}