[6.x] Try clicking all elements before throwing ElementClickInterceptedException
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to
click()a selector that appears multiple times on the page, it will match the first one and click it. This causes trouble when working with nested modals.For example, I have a base modal that has
dusk="close-modal"on the close button. If I have nested modals, I can't reliably click that close button with->click('@close-modal'). Depending the order of the modals in the html, it will either work or throw the following exception:This PR changes the
click()method to try and click all matching elements before throwing theElementClickInterceptedExceptionexception. This change should be fully backwards compatible.