Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General maintenance, code styling, and add stopListening() for socket.io #210

Merged
merged 3 commits into from
Dec 1, 2018

Conversation

tlaverdure
Copy link
Contributor

Hey just wanted to provide some updates. Shouldn't be any errors or breaking changes.

  • Updated npm dependencies to clear some vulnerabilities
  • Use npm run build instead of npm run compile before publish to run compile and declaration scripts before publishing
  • Add declaration files to the distribution for typescript users (addresses Typings file for project #84)
  • Removed doc blocks where type definitions were in place. Seems redundant to have both now.
  • Add stopListening() to socket.io channel (closes Request: add unlisten method #51)

@taylorotwell
Copy link
Member

Published 1.5.0.

@yoyo930021
Copy link

m... package is breaking change about module standard.
CommonJS -> ES6
if use require to add this lib, will break.

@tlaverdure
Copy link
Contributor Author

How are you using this package? I know most people in their laravel apps use mix to bundle with webpack.

@yoyo930021
Copy link

@tlaverdure

webpack can use more module standard.
but

before

const Echo = require('laravel-echo')

now must

const Echo = require('laravel-echo').default

if use

import Echo from 'laravel-echo'

Unaffected

@udanpe
Copy link

udanpe commented Dec 3, 2018

@tlaverdure Most people it's how much? Other not people? I can't do this. I must clone repository. I am disappointed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: add unlisten method
4 participants