Prevent make:migration from creating duplicate classes

laravel · Jul 22, 2016 · 49002cf · 49002cf
1 parent ceccdf7
commit 49002cf
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Illuminate/Database/Migrations/MigrationCreator.php b/src/Illuminate/Database/Migrations/MigrationCreator.php
@@ -41,9 +41,16 @@ public function __construct(Filesystem $files)
      * @param  string  $table
      * @param  bool    $create
      * @return string
+     * @throws \Exception 
      */
     public function create($name, $path, $table = null, $create = false)
     {
+        // Prevent creating a duplicate class name.
+        $className = $this->getClassName($name);
+        if (class_exists($className)) {
+            throw new \Exception("$className already exists");
+        }
+
         $path = $this->getPath($name, $path);
 
         // First we will get the stub file for the migration, which serves as a type

diff --git a/tests/Database/DatabaseMigrationCreatorTest.php b/tests/Database/DatabaseMigrationCreatorTest.php
@@ -47,6 +47,21 @@ public function testTableCreationMigrationStoresMigrationFile()
         $creator->create('create_bar', 'foo', 'baz', true);
     }
 
+    public function testTableUpdateMigrationWontCreateDuplicateClass()
+    {
+        $creator = $this->getCreator();
+        eval("class UpdateBar{}");
+
+        try {
+            $creator->create('update_bar', 'foo');
+        } catch(\Exception $e) {
+            $this->assertEquals($e->getMessage(), "UpdateBar already exists");
+            return;
+        }
+
+        $this->fail();
+    }
+
     protected function getCreator()
     {
         $files = m::mock('Illuminate\Filesystem\Filesystem');