-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php artisan make:auth command overrides the existing views by default #18309
Comments
|
@mg-freelancer well I happened to be using a layout with the same name. Since the file existing at the time the command was executed, the command should not assume that it can just override all my work just because there is a naming conflict. It is best to let the use make that decision. |
@CrestApps I also think that is important check if already exist the views because in this case the name of the layout is very common in applications. This could be useful when the developer makes a custom scaffold command and he wants prevent that default commands and thirds commands overwrite the views, in case of controllers, configs, services, etc not is useful. |
|
That's true @srmklive, but it should definitely show an error if those files already exist and not overwrite them. |
Feel free to send a PR. |
I've already created the app file in layouts, help plz |
artisan make:auth has completely overwritten my HomeController with empty controller content |
Description:
Where I issue
php artisan make:auth
command to use the authorization setup. The command overrode mylayout/app.blade.php
file. This caused me to lose my work!The command should check if the files already exists before overriding the file. Instead of overriding, it should throw a warning and if the use wishes to override the files he/she can run the command with the
--force
option.Steps To Reproduce:
create a file called app.blade.php in the
views/layouts
folder and write some codeThen execute
php artisan make:auth
commandThe text was updated successfully, but these errors were encountered: