[5.1] WIP: Changes to implement custom pivot model events on attach & detach.

[olsgreen]

Hey,

Implemented fully backwards compatible changes to properly fire events for custom pivot model attachment & detachment.

Also implemented a more fluent way of setting custom pivot models in their relation accessors as such:

public function relation()
{
    return $this->belongsToMany(\My\Name\Relation::class)
        ->setPivotModel(\My\Name\CustomPivotModel::class);
}

Thoughts?

[GrahamCampbell]

You know you could have just download the diff from StyleCI and applied it using git apply rather than trying to fix it manually and still not getting it right.

[olsgreen]

@GrahamCampbell missed the option to download the diff from StyleCI, thanks for pointing that out. Rushed manual fix commit from departure lounge at Gatwick at 4am, I should have known better! Any comments on the proposal itself?

[jbrooksuk]

Are you not missing a return type here?

[taylorotwell]

Going to hold off on this. You can basically do this yourself by writing a method on your model. Say you have a user that has roles. Instead of using $user->roles()->attach()... write a $user->addRole($role) method that does what you want and fires the custom events you want for your application.

[samwigginshal]

Why not fire events for pivot attach and detach methods? Seems like a perfectly logical thing to do. Events are fired on every model persistence method after all. Also, @taylorotwell your solution it's fine if used before an app has already been created but retrospectively would be a pain to refactor