[5.1] Ensure ModelIdentifier use write PDO connection. #12794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with SerializesModels, it is possible that when Queue attempts to work on the job the model is yet available on the read PDO connection, therefore `findOrFail()` would just fail, On heavy server load, it is possible that the latency is big enough the max out the number of attempts configured for queue. Signed-off-by: crynobone <[email protected]>
GrahamCampbell
changed the title
taylorotwell
added a commit
that referenced
this pull request
Mar 19, 2016
[5.1] Ensure ModelIdentifier use write PDO connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
SerializesModels, it is possible that when Queue attempts to work on the jobthe model is yet to be available on the read PDO connection, therefore
findOrFail()would just fail.On heavy server load, it also possible that the latency is long enough to max out the number of attempts
configured for queue.
Signed-off-by: crynobone [email protected]