[5.2] update httponly flags #12818
Closed
[5.2] update httponly flags #12818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,7 +135,7 @@ protected function addCookieToResponse($request, $response) | |||
| $response->headers->setCookie( | |||
| new Cookie( | |||
| 'XSRF-TOKEN', $request->session()->token(), time() + 60 * 120, | |||
| $config['path'], $config['domain'], $config['secure'], false | |||
| $config['path'], $config['domain'], $config['secure'], $config['http_only'] | |||
There was a problem hiding this comment.
This will break on systems were that key does not exist.
|
Okay @GrahamCampbell, it should be fixed now... |
|
Test seems to be failing because of this commit: b2f29b7 |
| @@ -135,7 +135,7 @@ protected function addCookieToResponse($request, $response) | |||
| $response->headers->setCookie( | |||
| new Cookie( | |||
| 'XSRF-TOKEN', $request->session()->token(), time() + 60 * 120, | |||
| $config['path'], $config['domain'], $config['secure'], false | |||
| $config['path'], $config['domain'], Arr::get($config, 'secure', false), Arr::get($config, 'http_only', true) | |||
There was a problem hiding this comment.
Wouldn't this introduce a breaking change/behaviour change?
Currently, http_only is set to false, but with this change (and without updating laravel/laravel configuration), http_only would default to true.
There was a problem hiding this comment.
Yes, this would be breaking.
|
@it-can stop changing unrelated code and just make your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a updated version of #12809
in StartSession I also changed this:
to
Is this correct?