[5.2] Fix Sparkpost Driver

[billmn]

This PR fix some issues of the Sparkpost driver, like:

• Fix recipient fields: [5.2] Sparkpost bcc #13237 (comment)
• Fix issue on sending attachments: [5.2] Fix SparkPost doesn't send attachments #13577 (comment)
• Added support for message plain version

Tested with all combinations of TO, CC and BCC fields (with single and multiple addresses) and with/without attachments.

Feedback are welcome.

[GrahamCampbell]

Thanks @billmn. Pinging @pochocho for feedback please.

[pochocho]

Ran some tests looks good. The only thing I did notice though is that when sending using both "To" and "BCC" the BCC recipients doesn't see his email on the recipient list. Only the ones passed as "To". @billmn @GrahamCampbell

[taylorotwell]

@pochocho so there is still a bug? Why does this seem so much harder than the other mail drivers? :|

[pochocho]

@taylorotwell we'll with my previous PR the recipientes thing was solved. @billmn can you add the attachments fix without changing how I generated the recipients array?

[billmn]

@pochocho In your PR (#13361) you have only set owned address to the "header_to" parameter. This means that every recipient see only own email address in TO field and doesn't see any other recipient (of TO or CC field).

@pochocho Why do you want that BCC recipients see own email on the recipient list?

I have sent an email like below using: Sparkpost Driver, Mandrill Driver, SMTP Driver, from Gmail webmail and from Office 365 webmail. None of these show own email in TO field for BCC recipients.

Mail::send(['html', 'plain'], [], function($message) {
    $message
        ->to([
            '[email protected]',
        ])
        ->cc([
            '[email protected]',
        ])
        ->bcc([
            '[email protected]',
            '[email protected]',
        ])
        ->subject('SparkPost Test')
        ->attach(public_path('robots.txt'))
        ->attach(public_path('web.config'));
});

@taylorotwell Seems harden because, to avoid that TO field is empty when are only BCC recipients, it was removed the use of "email_rfc822" parameter: #13237

I have sent some email with only BCC recipients using SMTP Driver, Mailgun driver and from Gmail webmail ... the TO field is empty. I don't have a Mandrill account so I cannot test this.

@taylorotwell @GrahamCampbell Sincerely I'm not convinced it's worth complicating the driver management to fill the TO field when are only BCC recipients. With the other email drivers is already like that. What is your opinion? Back or not to "email_rfc822"?

[RicardoRamirezR]

The TO filed should not be filled with anything other than the TO content.

[taylorotwell]

Where are we at with this? Does this PR still have bugs or not?

[billmn]

@taylorotwell Not for me but I'm waiting some feedback from my previous comment.

Personally, I think is better restore "email_rfc822" parameter to have the same simplicity like other email driver.

[taylorotwell]

Yes why is this so complicated compared to the other drivers?

[billmn]

@taylorotwell Take a look here: #13237 (comment)

To avoid that TO field is empty when are only BCC recipients, it was removed the use of "email_rfc822" parameter and after that the code is more complicated compared to other drivers.

[taylorotwell]

Yeah can someone just PR back to the simple version please?

On May 30, 2016, at 9:54 AM, Davide Bellini [email protected] wrote:

@taylorotwell https://github.com/taylorotwell Take a look here: #13237 (comment) #13237 (comment)
To avoid that TO field is empty when are only BCC recipients, it was removed the use of "email_rfc822" parameter and after that the code is more complicated compared to other drivers.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #13755 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAcRfj2_7bIEdAUZimK_wF_r6qRSzQ0Gks5qGvolgaJpZM4IpIIz.

[billmn]

Yes, I can do it

[billmn]

Closed in favour of this #13780