[5.3] Bind serve cmd to 127.0.0.1 instead of localhost #16937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On latest Mac (Sierra) and perhaps earlier,
localhost
is using the ipv6 network.This creates behavior like the following:
This is probably a confusing error for those hitting it when using
127.0.0.1
.We can make sure we bind to ipv4 by either binding to
0.0.0.0
or127.0.0.1
. Binding to127.0.0.1
is safer of course, and doesn't really change expected behavior (since ipv6 is not prevalent still and we're just talking localhost networks here).This change would behave like this:
Other OS considerations: