[5.5] Ensure getJobIds always return an array. #19232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusmyers
added a commit
to marcusmyers/framework
that referenced
this pull request
Jul 31, 2017
* 'master' of github.com:laravel/framework: (264 commits) fix bug Ensure getJobIds always return an array. (laravel#19232) Use Str:: class. (laravel#19221) Add a PasswordReset event. (laravel#19188) Remove all Arr:: helpers. (laravel#19219) Also test PHP 7.1 with lowest and stable setup. (laravel#19209) No need to reinstall Travis as we only test PHP>=7.0 (laravel#19210) Also disable Xdebug for PHP 7.1 (laravel#19211) Fix typo. (laravel#19216) Remove all Arr:: helpers. (laravel#19218) refactor container (laravel#19201) formatting fix formatting add thumb_url to Slack Attachment https://api.slack.com/docs/message-attachments#thumb_url Updated v5.5 release notes Use Authenticatable-functionality to update remember_token add method for easier error bag checking add `abilities` method to Gate contract (laravel#19173) update allow using assertSessionHasErrors to look into different error bags ...
|
with Collections doesn't work example: |
|
That is not a valid way to call the command. |
|
This problem, when upgrade from 5.4 to 5.5, prompted me to think that the Collection should have the __toArray() method implemented. Because something as simple as a type cast (array) breaks behavior. Despite the fact that collections work quietly with "foreach" and "count" It turns out that the Collections want to appear as an array, but are not converted to an array. |
|
The code you had before was never supported, and worked by chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
getJobIdsalways return an array.