Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Make RequestGuard Macroable #19569

Merged
merged 2 commits into from
Jun 12, 2017
Merged

[5.4] Make RequestGuard Macroable #19569

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
112c7b1
Create RequestGuard.php
hezhiying Jun 12, 2017
a13c78c
Update RequestGuard.php
taylorotwell Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Illuminate/Auth/RequestGuard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@

use Illuminate\Http\Request;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Support\Traits\Macroable;

class RequestGuard implements Guard
{
use GuardHelpers;
use GuardHelpers,Macroable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a space after the comma

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psr-2 says There MUST be one use keyword per declaration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True @BrandonShar but in this case this is not a declaration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh, read too fast!


/**
* The guard callback.
Expand Down