[5.5] Cache: allows DateInterface and DateInterval #20034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
commented
Jul 13, 2017
| @@ -37,7 +37,7 @@ public function pull($key, $default = null); | |||
| * | |||
| * @param string $key | |||
| * @param mixed $value | |||
| * @param \DateTime|float|int $minutes | |||
| * @param \DateTimeInterface|\DateInterval|float|int $minutes | |||
There was a problem hiding this comment.
We could probably have mixed there, but I've let this on purpose; this can be modified before 5.5 release if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment when using the Cache repository, we can only pass an instance of
\DateTimeor an integer for the duration.This is therefore impossible to use
\DateTimeImmutablefor example.Also we sometimes wish to use a
\DateInterval.This PR allows to use any kind of
\DateInterface,\DateIntervaland integers