[5.5] Improved mysql drop all tables #20536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkmadushan
changed the title
|
On the PostGres version we escaped the database tables: We should probably do that here too? |
|
@laurencei I tested this and it's working. we can't use double quotes but we can use backtick. Is it necessary? |
|
@lkmadushan it's necessary to use reserved words as identifiers. |
lucasmichot
reviewed
Aug 13, 2017
| @@ -43,12 +43,34 @@ public function getColumnListing($table) | |||
| */ | |||
| public function dropAllTables() | |||
| { | |||
| $this->disableForeignKeyConstraints(); | |||
| $tables = []; | |||
There was a problem hiding this comment.
No need to go further if $this->getAllTables() is empty
There was a problem hiding this comment.
Thanks. Will fix that 👍
lkmadushan
force-pushed
the
improved-mysql-drop-all-tables
branch
2 times, most recently
from
55aa8ac to
52060d4
Compare
| */ | ||
| public function compileDropAllTables($tables) | ||
| { | ||
| return 'drop table `'.implode('`,`', $tables).'`'; |
There was a problem hiding this comment.
Why are you not using our already existing "wrap" functions?
lkmadushan
force-pushed
the
improved-mysql-drop-all-tables
branch
2 times, most recently
from
c265a3d to
6261227
Compare
lkmadushan
force-pushed
the
improved-mysql-drop-all-tables
branch
from
6261227 to
ea3b259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current implementation runs N queries when database has N number of tables. this PR only run 2 queries to drop all tables.
Previous:
Now:
this implementation already exists for other database drivers. but mysql missed that somehow.