Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow notification's template to be changed #21154

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

mateusjatenee
Copy link
Contributor

Right now you can change the default markdown template either by changing the property or by creating another class that extends MailMessage and changing it there. This PR would allow something like this:

    public function toMail($notifiable)
    {
        return (new MailMessage)
            ->template('emails::foo')
            ->subject('Account Created')
            ->line('Welcome to foo app, bla bla bla')
            ->action('See Dashboard', url('/'))
            ->line('Thanks!');
    }

Not a new feature, but I think it looks way better this way.

Perhaps we could allow the default markdown template to be published and then the user could change it?

@taylorotwell taylorotwell merged commit fb03b11 into laravel:5.5 Sep 13, 2017
@mateusjatenee mateusjatenee deleted the notification-template branch September 13, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants