[5.5] Fix Database Collection Fresh for deleted records #21159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting a
fresh()
database collection, if any item has been deleted in a way that the collection itself is not aware,fresh()
will fail withundefined offset
The problem is because
$model->exists
will only returnfalse
if we use the same collection to delete the records. When deleting the records without the collection's knowledge,$model->exists
will still return true, but$freshModels
will not have that record.