[5.5] Add buildToDictionary Method #21505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've came across the need to build a dictionary a few times and each time it's something ugly or overly busy (doing too much for what it is). I found the perfect use case,
HasOneOrMany
'sbuildDictionary
method.This extracts a bit of logic from the
mapToGroups
method; no extra code is added, it's just extracted.See this Twitter chain for a bit of context: https://twitter.com/ConnorVG/status/913062913837060098
Please note, I haven't added tests for
mapToDictionary
as-of yet (though they're currently covered bymapToGroups
, it will still need its own tests obviously).