Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Rename example component to keep consistency with laravel/laravel repo #21685

Merged
merged 1 commit into from
Oct 16, 2017
Merged

[5.5] Rename example component to keep consistency with laravel/laravel repo #21685

merged 1 commit into from
Oct 16, 2017

Conversation

pawelmysior
Copy link
Contributor

The example Vue.js component was renamed in the laravel/laravel repo in this pull request: laravel/laravel#4447. This was done in order to follow the Vue.js style guide.

I've made the same changes in the vue preset stubs.

@pawelmysior pawelmysior changed the title Rename example component to keep consistency with laravel/laravel repo [5.5] Rename example component to keep consistency with laravel/laravel repo Oct 16, 2017
@taylorotwell taylorotwell merged commit 3423fdc into laravel:5.5 Oct 16, 2017
@pawelmysior pawelmysior deleted the rename-vue-example-component branch October 16, 2017 12:24
@bbashy
Copy link
Contributor

bbashy commented Oct 16, 2017

@pawelmysior They also changed the component name to example-component?

@pawelmysior
Copy link
Contributor Author

Right! Missed it, I'll make another PR. Thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants