Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Fixed incorrect description type #22449

Merged
merged 1 commit into from
Dec 16, 2017
Merged

[5.5] Fixed incorrect description type #22449

merged 1 commit into from
Dec 16, 2017

Conversation

GrahamCampbell
Copy link
Member

This is the description that is passed to Symfony console objects on construct. They should not be null. This is a bug, and is strictly enforced in Symfony 4, so this PR forms more ground work for getting onto Symfony 4 too.

TLDR:

  1. Description must be a not-null string.
  2. Is strictly enforced on Symfony 4.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@taylorotwell taylorotwell merged commit 0c63db4 into 5.5 Dec 16, 2017
@GrahamCampbell GrahamCampbell deleted the type-error branch December 16, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants