Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Allow HtmlString as line in notifications MailMessage #22473

Conversation

webkonstantin
Copy link
Contributor

@webkonstantin webkonstantin commented Dec 19, 2017

Allows for

public function toMail($notifiable)
{
    $line = new HtmlString('Hello <strong>world</strong>');
    
    return (new MailMessage)->with($line);
}

@sisve
Copy link
Contributor

sisve commented Dec 19, 2017

Perhaps allow the Htmlable interface instead of the HtmlString implementation?

@webkonstantin webkonstantin force-pushed the allow-html-string-in-notifications-mail-message branch from f885e78 to 962eca1 Compare December 19, 2017 10:18
@webkonstantin
Copy link
Contributor Author

@sisve sure. fixed, thanks

@taylorotwell taylorotwell merged commit 9982bce into laravel:5.5 Dec 19, 2017
@Miguel-Serejo
Copy link

Should have changed the title to reflect the change, now the change list in the tag is wrong.

https://github.com/laravel/framework/releases/tag/v5.5.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants