[5.5] Fix: verify csrf token allows to except full urls #22619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
laurencei
reviewed
Jan 2, 2018
| @@ -104,7 +104,7 @@ protected function inExceptArray($request) | |||
| $except = trim($except, '/'); | |||
| } | |||
|
|
|||
| if ($request->is($except)) { | |||
| if ($request->url() == $except || $request->is($except)) { | |||
|
Would it need wildcards support as well? For consistency with the previously existing |
|
I believe this PR is missing tests. Could you add some? |
|
@BenCavens: Please add a test. I don't know what this PR does and can't add it the changelog. |
|
I'll try to add some tests. |
|
Can you please tell if wildcard support should be added? (I'd bend supposing it should be) Also, may I ask for a use case, where you have to use full urls instead of paths? |
|
@vlakoff @tillkruss I've created a new PR which adds the wildcard support as well as the necessary tests: #22661 I'm looking forward to your feedback. thx |
|
@BenCavens: Thanks, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can leave out certain URLs from CSRF token verification by adding them to the
exceptarray. This is provided with an out-of-the-box laravel application.However, this only works if you add the paths and not the full URLs. This PR makes sure it is also possible to provide full URLs to this except array.