[5.6] Integration test to avoid repetitive pagination PR with columns

[deleugpn]

As Taylor recently said, in the last week 3 people already tried PRing a change to the Builder that passes the $columns into the getCountForPagination(). Unfortunately, that doesn't work when you use more than one column and it breaks the SQL being generated.

This is an attempt to avoid people from trying that again in the future. They'll be able to see for themselves that their change breaks on TravisCI. If somebody can apply a change that doesn't break this test, maybe that would be a PR worth looking into.

References:
#23255, #23214, #23209

Edit: StyleCI is failing but I don't know what is the issue as it's failing to analyze. ping @GrahamCampbell

[taylorotwell]

Does this test break with the change people have tried to make?

[deleugpn]

Yes.

root@0ad09383aa5d:/var/www/laravel-framework# ./vendor/bin/phpunit --group=f
PHPUnit 6.5.5 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.12
Configuration: /var/www/laravel-framework/phpunit.xml.dist

E                                                                   1 / 1 (100%)

Time: 1.72 seconds, Memory: 46.00MB

There was 1 error:

1) Illuminate\Tests\Integration\Database\EloquentPaginateTest\EloquentPaginateTest::test_pagination_on_top_of_columns
Illuminate\Database\QueryException: SQLSTATE[HY000]: General error: 1 wrong number of arguments to function count() (SQL: select count("id", "title") as aggregate from "posts")

/var/www/laravel-framework/src/Illuminate/Database/Connection.php:664
/var/www/laravel-framework/src/Illuminate/Database/Connection.php:624
/var/www/laravel-framework/src/Illuminate/Database/Connection.php:333
/var/www/laravel-framework/src/Illuminate/Database/Query/Builder.php:1748
/var/www/laravel-framework/src/Illuminate/Database/Query/Builder.php:1733
/var/www/laravel-framework/src/Illuminate/Database/Query/Builder.php:1833
/var/www/laravel-framework/src/Illuminate/Database/Query/Builder.php:1806
/var/www/laravel-framework/src/Illuminate/Database/Eloquent/Builder.php:708
/var/www/laravel-framework/src/Illuminate/Database/Eloquent/Model.php:1504
/var/www/laravel-framework/src/Illuminate/Database/Eloquent/Model.php:1516
/var/www/laravel-framework/tests/Integration/Database/EloquentPaginateTest.php:36