[5.8] Add bindings and singletons to the ServiceProvider
#27638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this PR is preaty the same as laravel#27565. We do not have any reason for checking if property exist, in cas if we could just get property values ;)
| /** | ||
| * @var array | ||
| */ | ||
| public $bindings = []; |
There was a problem hiding this comment.
Maybe make it protected?
There was a problem hiding this comment.
then we should add the getter
There was a problem hiding this comment.
Yes, my mistake. Haven't checked that it's used outside of the base provider.
| /** | ||
| * @var array | ||
| */ | ||
| public $singletons = []; |
There was a problem hiding this comment.
Maybe make it protected?
|
I don't think I'm going to add anymore to the service provider for now. |
TBlindaruk
deleted the
add_bind_and_singleton_to_base_service_provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registermethod to the ServiceProvider #27565. We do not have any reason for checking if property exist, in cas if we could just get property values ;)