Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Don't execute query when ids are empty Arrayable #28432

Merged
merged 4 commits into from
May 7, 2019
Merged

[5.8] Don't execute query when ids are empty Arrayable #28432

merged 4 commits into from
May 7, 2019

Conversation

mnabialek
Copy link
Contributor

Previous condition was met only if $ids were empty array. If they were empty instance of Arrayable (for example collection with no elements) condition was false and query was executed.

@driesvints driesvints dismissed their stale review May 7, 2019 08:15

I was wrong 🙊

@taylorotwell taylorotwell merged commit 7f78d95 into laravel:5.8 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnabialek @driesvints @taylorotwell