Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Support for FILTER_FLAG_EMAIL_UNICODE via "email:filter_unicode" #32711

Merged
merged 1 commit into from
May 7, 2020
Merged

[7.x] Support for FILTER_FLAG_EMAIL_UNICODE via "email:filter_unicode" #32711

merged 1 commit into from
May 7, 2020

Conversation

mpyw
Copy link
Contributor

@mpyw mpyw commented May 7, 2020

Overview

This PR enables us to validate email with FILTER_FLAG_EMAIL_UNICODE flag. It allows any unicode characters in local-part.

Unicode in local-part Unicode in domain-part
rfc
filter
filter_unicode

I decided to submit this PR according to the following reason:

  • egulias/EmailValidator has some bugs. Our service is in trouble because the number of wrong registrations is increasing due to them.
  • We don't want to directly allow unicode characters in domain-part. We encode them using Punycode, such as xn--***.

Links

@mpyw mpyw changed the title Support for FILTER_FLAG_EMAIL_UNICODE via "email:filter_unicode" [7.x] Support for FILTER_FLAG_EMAIL_UNICODE via "email:filter_unicode" May 7, 2020
@taylorotwell taylorotwell merged commit 1a9d6a7 into laravel:7.x May 7, 2020
@mpyw mpyw deleted the add-filter-flag-email-unicode branch May 7, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants