[7.x] Fixed increment bug that changes expiration to forever #32875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was introduced recently when changing:
```
if ($existing = $this->get($key)) {
```
to
```
if (! isset($this->storage[$key])) {
```
When attempting to increment a value that starts from zero (0), before it worked correctly in that it was simply returning true in that a value was set. However, now when `$this->get($key)` returns 0 since we are incrementing from 0, it evaluates as false and thus changes expiration to "forever". This causes issues for testing rate limiting because nothing ever "expires".
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced recently when changing:
to
When attempting to increment a value that starts from zero (0), before it worked correctly when evaluating if the item was in the cache. However, now when
$this->get($key)returns 0 since we are incrementing from 0 (the item has a value of 0), it evaluates as false and thus changes expiration to "forever". This causes issues for testing rate limiting because nothing ever "expires".