[7.x] Add a more generic minute schedule method #33380
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR was inspired by #33379
Rather than adding a method for every iteration of minute intervals, the thought is to have one method that accepts a parameter.
If there are any suggestions for a better method name, definitely open to them.
The only concern here is that we make it clear in the documentation how this actually works, specifically with values that are not factors of 60. For example, a value of
*/17
will run at the 0, 17, 34, and 51 minutes, and then start over again at zero on the next hour, so the expressions is not truly running every 17th minute.If we can come up with a readable name, we could possibly deprecate and remove the existing function like
->everyFiveMinutes()
,->everyFifteenMinutes()
, etc.