[7.x] Throw a TypeError if concrete is not a string or closure

src/Illuminate/Container/Container.php

@@ -218,6 +218,8 @@ public function isAlias($name)
      * @param  \Closure|string|null  $concrete
      * @param  bool  $shared
      * @return void
+     *
+     * @throws \InvalidArgumentException
      */
     public function bind($abstract, $concrete = null, $shared = false)
     {
@@ -234,6 +236,10 @@ public function bind($abstract, $concrete = null, $shared = false)
         // bound into this container to the abstract type and we will just wrap it
         // up inside its own Closure to give us more convenience when extending.
         if (! $concrete instanceof Closure) {
+            if (! is_string($concrete)) {
+                throw new \InvalidArgumentException('Concrete implementation must be a string or closure');
+            }
+
             $concrete = $this->getClosure($abstract, $concrete);
         }
 
@@ -337,6 +343,8 @@ public function addContextualBinding($concrete, $abstract, $implementation)
      * @param  \Closure|string|null  $concrete
      * @param  bool  $shared
      * @return void
+     *
+     * @throws \InvalidArgumentException
      */
     public function bindIf($abstract, $concrete = null, $shared = false)
     {
@@ -351,6 +359,8 @@ public function bindIf($abstract, $concrete = null, $shared = false)
      * @param  string  $abstract
      * @param  \Closure|string|null  $concrete
      * @return void
+     *
+     * @throws \InvalidArgumentException
      */
     public function singleton($abstract, $concrete = null)
     {

tests/Container/ContainerTest.php

@@ -120,6 +120,15 @@ public function testSharedConcreteResolution()
         $this->assertSame($var1, $var2);
     }
 
+    public function testBindFailsLoudlyWithInvalidArgument()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $container = new Container;
+
+        $concrete = new ContainerConcreteStub();
+        $container->bind(ContainerConcreteStub::class, $concrete);
+    }
+
     public function testAbstractToConcreteResolution()
     {
         $container = new Container;